Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Updated docs for R-package installation #14269

Merged
merged 4 commits into from
Apr 16, 2019
Merged

Updated docs for R-package installation #14269

merged 4 commits into from
Apr 16, 2019

Conversation

piyushghai
Copy link
Contributor

Description

Added a note about having cuDNN installation as a pre-req for running R-packages.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • Code is well-documented:
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@hetong007 @aaronmarkham

hetong007
hetong007 reviewed Feb 27, 2019
View reviewed changes
docs/install/index.md Outdated Show resolved Hide resolved
hetong007
hetong007 suggested changes Feb 27, 2019
View reviewed changes
docs/install/index.md Outdated Show resolved Hide resolved
@hetong007
Copy link
Contributor

Do we still support cu80 in 1.4 release?

@piyushghai
Copy link
Contributor Author

Do we still support cu80 in 1.4 release?

There were issues when I tried to make the packages for cu80.
I was following the steps given here :
http://mxnet.incubator.apache.org/versions/master/install/build_from_source.html

@hetong007
Copy link
Contributor

If I recall correctly, you need an earlier version of visual studio to build cu80. Have you tried that?

@piyushghai
Copy link
Contributor Author

If I recall correctly, you need an earlier version of visual studio to build cu80. Have you tried that?

Yes. I tried with VS 2015 (not 2017). Still did not work.

@hetong007
Copy link
Contributor

@ankkhedia Since you have built cu80 for MXNET R 1.3, would you please help @piyushghai to build cu80? It is helpful for us to go through and fix the configuration, so that we can have a smooth pipeline for the R releases in the future.

@anirudhacharya
Copy link
Member

anirudhacharya commented Mar 4, 2019 •
edited
Loading

@piyushghai did you get a chance to speak to Ankit about the windows build. I recollect you were working with him on the 1.4 release build.

@mxnet-label-bot add [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Mar 4, 2019
@ankkhedia
Copy link
Contributor

@hetong007 unfortunately, I tried building it for cu80 using VS2015 but was not able to get it working for 1.3

@hetong007
Copy link
Contributor

If 1.4 doesn't come with cu80 binary, don't we want to remove cu80 in the doc?

@piyushghai
Copy link
Contributor Author

If 1.4 doesn't come with cu80 binary, don't we want to remove cu80 in the doc?

Removed it.

@karan6181
Copy link
Contributor

@piyushghai Thank you for your contribution. Can you please look into this PR? is there any blocker?
Also, Please look at the CI why is it failing?

@abhinavs95
Copy link
Contributor

@hetong007 Could you have a look again and see if your comments are addressed? Thanks

@szha
Copy link
Member

szha commented Apr 3, 2019

@piyushghai thanks for the patch. This PR needs a rebase to the latest master branch. Would you mind?

@piyushghai
Copy link
Contributor Author

@piyushghai thanks for the patch. This PR needs a rebase to the latest master branch. Would you mind?

Done. :)

@aaronmarkham
Copy link
Contributor

Is this intended to be Windows only?
I see the update here, but for no other OS:
http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-14269/8/install/index.html?platform=Windows&language=R&processor=GPU

@piyushghai
Copy link
Contributor Author

Is this intended to be Windows only?
I see the update here, but for no other OS:
http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-14269/8/install/index.html?platform=Windows&language=R&processor=GPU

Yes. This particular instruction update is Windows only.

@hetong007 hetong007 merged commit 51d3291 into apache:master Apr 16, 2019
@piyushghai piyushghai deleted the r_doc_fix branch April 16, 2019 19:25
kedarbellare pushed a commit to kedarbellare/incubator-mxnet that referenced this pull request Apr 20, 2019
@piyushghai @kedarbellare
Updated docs for R-package installation (apache#14269)
bbcc269 
* Updated docs for R-package installation

* Addressed PR feedback

* Removed spaces in cuda100 path

* Removed cu80 mention
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
@piyushghai
Updated docs for R-package installation (apache#14269)
27fbeef 
* Updated docs for R-package installation

* Addressed PR feedback

* Removed spaces in cuda100 path

* Removed cu80 mention
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ankkhedia ankkhedia ankkhedia approved these changes

@aaronmarkham aaronmarkham aaronmarkham approved these changes

@hetong007 hetong007 hetong007 approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@piyushghai @hetong007 @anirudhacharya @ankkhedia @karan6181 @abhinavs95 @szha @aaronmarkham @marcoabreu